Updating Go sdk to include group_by at dashboard level#979
Draft
mawasthy-lgtm wants to merge 1 commit into
Draft
Updating Go sdk to include group_by at dashboard level#979mawasthy-lgtm wants to merge 1 commit into
mawasthy-lgtm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Go sdk to include group_by at dashboard level
✔️ How to Test
How do I run the relevant unit/integration tests?
Prerequisites
Go 1.19+ installed
Valid Linode API token with monitor permissions
Export LINODE_TOKEN environment variable for integration tests
Run all monitor alert definition unit tests:
UNIT TEST:
go test ./test/unit -run "..MonitorDashboard.." -v
Expected Output:
✅ TestListMonitorDashboards
✅ TestListMonitorDashboardsByID
✅ TestListMonitorDashboardsByServiceType
INTEGRATION TEST:
export LINODE_TOKEN="your-linode-api-token"
go test ./test/integration -run "TestMonitorDashboards_Get_smoke" -v
Test Coverage:
List Monitor Dashboards: Verifies listing all monitor dashboards returns correct data and structure.
List Monitor Dashboards By ID: Verifies fetching a single monitor dashboard by ID returns the expected dashboard.
List Monitor Dashboards By Service: Verifies listing dashboards filtered by service type returns the correct dashboards.
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.